Skip to content

Port to 20.04 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 1, 2020
Merged

Port to 20.04 #43

merged 5 commits into from
May 1, 2020

Conversation

rakshith-ravi
Copy link
Contributor

@rakshith-ravi rakshith-ravi commented Apr 30, 2020

I couldn't find a replacement for these packages:

libcloog-isl4
libelektra-dev
libiculx60
libmariadbclient18
libntdb1
libpolkit-backend-1-0
libsane-extras
libsane-extras-common
libv8-3.14.5
libv8-dev
vdpau-va-driver

Any idea on what to do about these packages? The docker image builds successfully without them though.

@jyn514 @nellshamrell

@Mark-Simulacrum
Copy link
Member

Locally, running 20.04, I see libmariadbclient-dev -- can you check that again? I can confirm that cursory searches do not yield results for the others.

@rakshith-ravi
Copy link
Contributor Author

Oh yeah, I forgot to mention that. The libmariadbclient-dev package exists, but seems to be clashing with libmysqlclient-dev. It wouldn't let me install them together.

@rakshith-ravi
Copy link
Contributor Author

rakshith-ravi commented Apr 30, 2020

Okay hold on, I think I may have confused the packages. libmariadbclient-dev works, but libmariadbclient18 doesn't seem to have an installation candidate. In fact, my PR has the libmariadbclient-dev and libmariadbclient-dev-compat package in it.

Sorry about the confusion. I'll update the initial post

@jyn514
Copy link
Member

jyn514 commented May 1, 2020

libmariadbclient18

This is left over from the initial commit, so I think as long as we have the development headers it's fine not to keep it.

libcloog-isl4
libntdb1

As mentioned in #42 (comment) I think it's fine to get rid of these.

libelektra-dev

This has not be packaged upstream, see ElektraInitiative/libelektra#3412. I think it's fine not to keep it in the meantime, we can add it back later if/when it gets packaged.

libiculx60
libpolkit-backend-1-0
libv8-3.14.5
libv8dev
vdpau-va-driver

These are also from the initial commit, I'm ok with not keeping them. There doesn't seem to be a replacement package in 20.04.

libsane-extras
libsane-extras-common

These appear to have been renamed to libsane and libsane-common, try adding those.

@jyn514 jyn514 mentioned this pull request May 1, 2020
@rakshith-ravi
Copy link
Contributor Author

Done. libsane and libsane-common is added. Not sure why the travis build was failing though. Something about a task not found.

@jyn514
Copy link
Member

jyn514 commented May 1, 2020

The error is

Lint error: packages.txt is not sorted

You can fix it with sort packages.txt > tmp && mv tmp packages.txt.

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked to remove a few duplicate versions. I haven't checked whether they were explicitly requested, if any of them were then don't remove them. You can check with git log -p packages.txt | grep <package name>.
Also, I want to check at some point that all the removed packages are no longer present in 20.04, I don't have time right now.

@rakshith-ravi
Copy link
Contributor Author

Updated

@jyn514
Copy link
Member

jyn514 commented May 1, 2020

Thanks so much for working on this!

@jyn514 jyn514 merged commit 3f383d7 into rust-lang:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants