Skip to content

s3: Increase put() timeout to 60sec #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

s3: Increase put() timeout to 60sec #3495

merged 1 commit into from
Apr 12, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 7, 2021

This is an alternative to #3494, which increases the timeout only for the relevant S3 PUT request.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Apr 7, 2021
@pietroalbini
Copy link
Member

Merged #3494

@jtgeibel jtgeibel mentioned this pull request Apr 12, 2021
Closed
@jtgeibel
Copy link
Member

For some reason, #3494 doesn't appear to have resolved the issue. The enforced timeout appears to still be 30 seconds. Let's see if this works. I expect we'll revert both of these commits once we get the size of the database export under control (#3479).

@jtgeibel jtgeibel reopened this Apr 12, 2021
@jtgeibel
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 12, 2021

📌 Commit 3547f66 has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Apr 12, 2021

⌛ Testing commit 3547f66 with merge 15c0e92...

@bors
Copy link
Contributor

bors commented Apr 12, 2021

☀️ Test successful - checks-actions
Approved by: jtgeibel
Pushing 15c0e92 to master...

@bors bors merged commit 15c0e92 into rust-lang:master Apr 12, 2021
@Turbo87 Turbo87 deleted the s3-timeout branch April 12, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jtgeibel jtgeibel

@pietroalbini pietroalbini

Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Turbo87 @pietroalbini @jtgeibel @bors