Skip to content

Show features of dependencies #3505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

bikeshedder
Copy link
Contributor

I keep getting asked why my crate depends on tokio besides it just needing a small subset of features: deadpool-rs/deadpool#88

This PR adds the list of features used from each dependency to the dependencies tab:

image

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @smarnach (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Turbo87 Turbo87 added A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works labels Apr 10, 2021
@Turbo87 Turbo87 force-pushed the show-features-of-dependencies branch from b7901c2 to aed14f8 Compare August 31, 2021 21:18
@Turbo87
Copy link
Member

Turbo87 commented Aug 31, 2021

Thanks for the initial work @bikeshedder! I've slightly improved the styling of the feature listing, and I think this is good to go now. :shipit:

Bildschirmfoto 2021-08-31 um 23 12 13

Bildschirmfoto 2021-08-31 um 23 12 31

@Turbo87 Turbo87 force-pushed the show-features-of-dependencies branch from aed14f8 to 63ebbde Compare August 31, 2021 21:24
@Turbo87 Turbo87 assigned locks and pichfl and unassigned smarnach Aug 31, 2021
@Turbo87 Turbo87 force-pushed the show-features-of-dependencies branch 3 times, most recently from e02debe to 42c874a Compare September 8, 2021 18:38
@Turbo87 Turbo87 requested review from locks and pichfl September 10, 2021 15:23
@Turbo87 Turbo87 unassigned locks and pichfl Sep 10, 2021
@Turbo87 Turbo87 force-pushed the show-features-of-dependencies branch 3 times, most recently from 4e1b463 to fb647d6 Compare September 17, 2021 21:47
@Turbo87 Turbo87 force-pushed the show-features-of-dependencies branch 3 times, most recently from 5e8c459 to 5c4ac9f Compare September 26, 2021 08:34
@Turbo87 Turbo87 force-pushed the show-features-of-dependencies branch from 5c4ac9f to efa122c Compare September 29, 2021 20:35
@Turbo87 Turbo87 force-pushed the show-features-of-dependencies branch from efa122c to 58514bc Compare October 1, 2021 14:33
@Turbo87
Copy link
Member

Turbo87 commented Oct 1, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 1, 2021

📌 Commit 58514bc has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Oct 1, 2021

⌛ Testing commit 58514bc with merge 3ec019e...

@bors
Copy link
Contributor

bors commented Oct 1, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 3ec019e to master...

@bors bors merged commit 3ec019e into rust-lang:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants