controllers::krate::publish: Move reading of tarball up from uploader to publish #4096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to publish Pull upward hex_cksum and verify_tarball to publish to the point before readme rendering - so that readme can leverage information from tarball. Additionally, it will avoid rendering readme for failure cases where the tarball doesn't verify.
This was referenced Oct 28, 2021
|
Pull number is a power of 2! (2^12) |
Turbo87
added
A-backend ⚙️
C-internal 🔧
|
@bors r+ |
|
📌 Commit 5da5717 has been approved by |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Oct 28, 2021
Add a test for verify_tarball Depends on #4096. (Because of community/community#4477 - it doesn't render the diff against #4096 - so you have to go to commits tab to see appropriate diff).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull upward hex_cksum and verify_tarball to publish
to the point before readme rendering - so that readme
can leverage information from tarball.
Additionally, it will avoid rendering readme for failure cases where
the tarball doesn't verify.
Will be useful to access cargo_vcs_info earlier on (for #3484)