Skip to content

settings/tokens/new: Add "Expiration" options #6648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 19, 2023

Default (No expiration):

Bildschirmfoto 2023-06-19 um 17 28 07

Available options:

Bildschirmfoto 2023-06-19 um 17 28 13

Preset expiration:

Bildschirmfoto 2023-06-19 um 17 28 21

Custom expiration date:

Bildschirmfoto 2023-06-19 um 17 28 38

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Jun 19, 2023
@Turbo87 Turbo87 requested a review from a team June 19, 2023 15:31
@Turbo87 Turbo87 force-pushed the token-expiry-input branch 2 times, most recently from ba30d25 to 61f6dd8 Compare June 19, 2023 15:45
@Turbo87 Turbo87 force-pushed the token-expiry-input branch from 61f6dd8 to fa29cd1 Compare June 20, 2023 19:21
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature! A UI looks like GitHub PAT's and should be easy to use :)

@Turbo87
Copy link
Member Author

Turbo87 commented Jun 21, 2023

UI looks like GitHub PAT's

yeah, I might have taken that as the inspiration... 😅

@Turbo87
Copy link
Member Author

Turbo87 commented Jun 22, 2023

Now that rust-lang/blog.rust-lang.org#1116 has been opened and nobody appears to have any objections on this implementation I'll go ahead and merge this PR :)

@Turbo87 Turbo87 merged commit 9cf9f1b into rust-lang:master Jun 22, 2023
@Turbo87 Turbo87 deleted the token-expiry-input branch June 22, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants