Add sudo mode acceptance tests, per #8210 feedback #8237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whichever stage of sudo grief we're at, we're now at acceptance.
I don't think there's anything surprising here. I used the yank button as a proxy for the general
PrivilegedAction
functionality rather than creating a new test-only component, since it's already onmain
and is unlikely to change significantly. Unit tests are covering all the actually interesting bits anyway.The one thing that I was surprised by is that the
qunit-dom
helpers were capable of clicking a button in a disabledfieldset
, even though that's not possible from the browser UI, which means I can't write a sensible "failed to yank" style test. (I tried a few different ways just to be sure.)