Introduce length limit on the description field
#8746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
eth3lbert
approved these changes
May 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8746 +/- ##
=======================================
Coverage 88.64% 88.64%
=======================================
Files 276 276
Lines 27549 27566 +17
=======================================
+ Hits 24421 24437 +16
- Misses 3128 3129 +1 ☔ View full report in Codecov by Sentry. |
Rustin170506
approved these changes
May 28, 2024
LawnGnome
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8739
This PR introduces a limit on the length of the
descriptionfield. Descriptions like https://crates.io/crates/docker-rust-api seem unreasonably long, so I've decided for an arbitrary limit of 1000 characters for now. As mentioned on the linked discussion, our frontend currently truncates the description to 200 characters in some places, so 1000 as a hard limit seem okay to me.