Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are no tests for a full build #822

Closed
pietroalbini opened this issue Jun 6, 2020 · 3 comments
Closed

There are no tests for a full build #822

pietroalbini opened this issue Jun 6, 2020 · 3 comments
Assignees
@pietroalbini
Labels
A-builds Area: Building the documentation for a crate C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-hard Effort: This will require a lot of work P-high High priority

Comments

@pietroalbini
Copy link
Member

We don't currently execute any kind of test to ensure a full build actually works. Such tests would've caught the root cause of today's outage.
@pietroalbini
Copy link
Member Author

I'll work on implementing those tests next week.

@pietroalbini pietroalbini self-assigned this Jun 6, 2020
@jyn514
Copy link
Member

jyn514 commented Jun 6, 2020

As a short-term thing, I think it would be fairly easy to add unit tests that we're using the crates.io API properly.

@jyn514 jyn514 mentioned this issue Jun 26, 2020
Merged
@jyn514 jyn514 added the P-high High priority label Jun 27, 2020
@jyn514 jyn514 mentioned this issue Jul 2, 2020
Closed
@jyn514 jyn514 added the A-builds Area: Building the documentation for a crate label Jul 4, 2020
@jyn514 jyn514 mentioned this issue Jul 6, 2020
Open
2 tasks
@jyn514 jyn514 added C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-hard Effort: This will require a lot of work labels Jul 14, 2020
This was referenced Aug 7, 2020
Merged
Closed
@Kixiron Kixiron mentioned this issue Aug 22, 2020
Open
@jyn514 jyn514 mentioned this issue Nov 16, 2020
Merged
@jyn514 jyn514 mentioned this issue Nov 24, 2020
Open
@jyn514 jyn514 mentioned this issue Jan 1, 2021
Merged
@jyn514
Copy link
Member

jyn514 commented Apr 17, 2021

This was fixed by #1309.

@jyn514 jyn514 closed this as completed Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pietroalbini pietroalbini

Labels
A-builds Area: Building the documentation for a crate C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-hard Effort: This will require a lot of work P-high High priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pietroalbini @jyn514