Fix collecting github stats after timezone-migration #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to check how to test this the best possible way |
|
I were able to reproduce the error locally, and the change fixes it. |
|
@pietroalbini this could be a fix, but it doesn't add tests to the previously untested code. I'm not sure what the strategy for these tests will be (mocking? some other technique?), if that's decided I could provide tests in the next days. Question is if we want to wait with this fix for the tests. |
syphar
force-pushed
the
fix-github-stats
branch
from
3026212 to
ac5bd4b
Compare
syphar
force-pushed
the
fix-github-stats
branch
from
ac5bd4b to
ac5b738
Compare
|
I don't think this should be blocked on tests, I see it as the same sort of issue as #822 where the tests need some design. |
jyn514
added
the
S-waiting-on-deploy
jyn514
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this could be a quickfix for #1234