split service&instance metrics, serve metrics for build-server & watcher #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Nemo157
reviewed
May 29, 2023
jyn514
added
S-waiting-on-author
* split service & instance metrics into separate objects, serve them via separate endpoints * add a small webserver to serve metrics for the build-server & registry watcher
syphar
added
S-waiting-on-review
Nemo157
reviewed
Jun 3, 2023
Nemo157
approved these changes
Jun 3, 2023
github-actions
bot
added
S-waiting-on-deploy
|
thank you for the help @Nemo157 ❤️ |
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO this is the last piece missing to close #795 , while touching it I also split the metrics (#1755), so collecting the metrics could be optimized.
I also tried to find a non-macro approach for the metrics definition & registration, perhaps migrating the instance-metrics too. (I'm taking ideas how to improve this further)