Skip to content

Fix feature flags count #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

Fix feature flags count #2799

merged 3 commits into from
Apr 14, 2025

Conversation

GuillaumeGomez
Copy link
Member

Fixes #1284.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner April 11, 2025 14:40
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 11, 2025
syphar
syphar requested changes Apr 12, 2025
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

only one (optional) thing,
also CI fails.

@GuillaumeGomez
Copy link
Member Author

Updated.

@GuillaumeGomez GuillaumeGomez enabled auto-merge (rebase) April 14, 2025 10:57
@GuillaumeGomez GuillaumeGomez merged commit fd7636c into rust-lang:master Apr 14, 2025
9 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-features-count branch April 14, 2025 10:57
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbstj fbstj fbstj left review comments

@syphar syphar syphar approved these changes

Assignees
No one assigned
Labels
S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird feature flag counting behavior
3 participants
@GuillaumeGomez @fbstj @syphar