Skip to content

Remove top-level re-export of Poll? #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
taiki-e opened this issue Sep 1, 2019 · 0 comments · Fixed by #1858
Closed

Remove top-level re-export of Poll? #1854

taiki-e opened this issue Sep 1, 2019 · 0 comments · Fixed by #1858

Comments

@taiki-e
Copy link
Member

taiki-e commented Sep 1, 2019

https://github.com/rust-lang-nursery/futures-rs/blob/90c83b8faca107e6c4db63d10b0d4f2ea36d6628/futures/src/lib.rs#L63
https://github.com/rust-lang-nursery/futures-rs/blob/90c83b8faca107e6c4db63d10b0d4f2ea36d6628/futures-core/src/lib.rs#L30

Unlike 0.1, traits such as Future cannot be implemented with only items exported at the top-level (needs Context).

In addition, as Future can be created by async-await, I think the advantage of doing this would be very small.

Related: #1069 (comment)

cc @seanmonstar @Nemo157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce top-level re-exports taiki-e/futures-rs
Remove top-level re-exports taiki-e/futures-rs
1 participant
@taiki-e