-
Notifications
You must be signed in to change notification settings - Fork 651
Remove top-level re-exports #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What’s the feeling on removing all the |
Personally I don't think I should depend on APIs that are not displayed in the documentation, so I would like to remove them,
I strongly agree. |
9092f63
to
7fdfdd5
Compare
So, I added a commit to reduce some top-level re-exports and changed the title of PR. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7fdfdd5
to
9fbacf1
Compare
Seems intra-doc has been improved. All of top-level reexports can be removed. |
I personally use these pretty often and find having to import from two different modules just to get |
46dadf1
to
e885bd7
Compare
@cramertj Okay, I separated the part not related to ext trait into #1858.
Is this be resolved by merging |
That would help, but IMO |
I noticed that the current one is useful when using with macro. use futures::{select, join, FutureExt, TryFutureExt}; Also, the removal of reexports of items other than traits that I originally wanted to do is included in #1858. |
Closes #1854