Skip to content

Minimize re-exports from rand #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2019
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 1, 2019

This should avoid all doc errors from rand.

@taiki-e
Copy link
Member Author

taiki-e commented May 1, 2019

The log has been reduced from 2584 lines to 2032 lines 🎉.

master: https://travis-ci.com/rust-lang-nursery/futures-rs/jobs/196780524
this PR: https://travis-ci.com/rust-lang-nursery/futures-rs/jobs/196918886

pub use rand::*;
pub use rand::{prelude::SliceRandom, thread_rng};

// HACK: Define dummy `ThreadRng` to avoid `intra_doc_link_resolution_failure` warning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wut. this is horrible

@cramertj cramertj merged commit 13a83fe into rust-lang:master May 2, 2019
@taiki-e taiki-e deleted the docs-rand branch May 3, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants