Remove uses of pin_project::project attribute #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pin-project will deprecate the project attribute due to some unfixable limitations. Refs: taiki-e/pin-project#225
taiki-e
commented
Jun 6, 2020
|
|
||
| use crate::fns::FnOnce1; | ||
|
|
||
| /// Internal Map future | ||
| #[pin_project(Replace)] | ||
| #[pin_project(Replace, project = MapProj, project_replace = MapProjOwn)] |
There was a problem hiding this comment.
It is not ideal that we need to have both Replace and project_replace = <name> as project_replace = <name> implies that a project_replace method is generated.
I'll fix it soon.
There was a problem hiding this comment.
Fixed in pin-project 0.4.20 (taiki-e/pin-project#243)
bors bot
added a commit
to taiki-e/pin-project
that referenced
this pull request
Jun 6, 2020
243: Allow `project_replace` argument to be used without `Replace` r=taiki-e a=taiki-e
Currently, both `Replace` and `project_replace = <name>` arguments are required to name the return value of `project_replace()` method.
```rust
#[pin_project(Replace, project_replace = EnumProjOwn)]
enum Enum<T> {
Variant(#[pin] T)
}
```
It is not ideal that we need to have both `Replace` and `project_replace = <name>` as `project_replace = <name>` implies that a `project_replace` method is generated.
This PR makes `project_replace` argument to use without `Replace` argument.
```diff
- #[pin_project(Replace, project_replace = EnumProjOwn)]
+ #[pin_project(project_replace = EnumProjOwn)]
enum Enum<T> {
Variant(#[pin] T)
}
```
Also, makes `project_replace` argument an alias for `Replace` so that it can be used without a value.
```rust
#[pin_project(project_replace)]
enum Enum<T> {
Variant(#[pin] T)
}
```
Related: rust-lang/futures-rs#2176 (comment) hyperium/hyper#2220 (comment)
Co-authored-by: Taiki Endo <[email protected]>
Nemo157
approved these changes
Jun 9, 2020
|
Thanks! The number of PRs you've done for this deprecation is pretty epic 😁 |
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 5, 2021
Remove uses of pin_project::project attribute
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 5, 2021
Remove uses of pin_project::project attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pin-project will deprecate the project attribute due to some unfixable
limitations.
Refs: taiki-e/pin-project#225
Although the deprecation of the project attribute has not been released yet, this PR is submitted in advance to avoid the CI from being broken by deprecated warnings.