Provide TestHarness to make testing future / combinator implementations easier. #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames an internal type away from deprecated terminology.
This change avoids the Arc allocation for each blocking call as well as eliminates the need to perform the Arc ref count increment if unnecessary.
Unfortunately, using an atomic requires a final atomic CAS within the "wakeup" mutex. This means we cannot use the thread park / unpark helpers from std. This change increases a single threaded "yield" benchmark by almost 40%.
This wrapper is similar to `Spawn` but is intended to be used from context of tests. As such, it provides a slightly different API as well as the ability to introspect task notifications.
|
Hm I'd imagine that if we want to make futures-based tests easier to write we could probably go farther? Maybe we could try to collect test-related helpers in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #597
This PR adds a new type:
executor::TestHarness. This type is very similar toSpawnbut is intended to be used from the context of tests. As such, it provides a slightly different API. While this functionality could be provided directly bySpawn,Spawnalready has a fairly busy API surface and some of the capabilities ofTestHarnessdoen't make as much sense when used in "real code".This PR only provides the ability to wrap a
Futurefor now, but at a later time, support forStreamandSinkcan be added.The idea would be for
TestHarness<impl Stream>to provide:impl Iteratorpoll_next(&mut self) -> Poll<Option<Self::Item>, Self::Error>wait_next_timeout(&mut self) -> Result<Option<Self::Item>, TimeoutError<Self::Error>>And for
TestHarness<impl Sink>:try_send(&mut self, item: T::SinkItem) -> StartSend<T::SinkItem, T::SinkError>send_timeout(&mut self, item: T::SinkItem) -> Result<(), SendTimeoutError<T::SinkItem, T::SinkError>>