Introduce WithExecutor adaptor #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cramertj
reviewed
Apr 2, 2018
futures-core/src/task/context.rs
Outdated
| /// | ||
| /// This advanced method is primarily used when building "internal | ||
| /// schedulers" within a task. | ||
| pub fn with_executor<'b>(&'b mut self, executor: Option<&'b mut Executor>) |
There was a problem hiding this comment.
IMO this should take the executor directly instead of an Option: the executor value should only ever be None when using the no-std version.
There was a problem hiding this comment.
Ah, okay! I think I was just a little confused by the fact that the Context::executor method is also flagged if_std! and returns an Option. Will change this!
|
Addressed feedback and rebased! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
WithExecutoradapter, which assigns an executor to be used when spawning tasks from within the future.The main driver for me is to enable the use-case of overriding the default thread pool for
block_on:By making this a combinator it opens up more use-cases, such as this pattern: