Bump libgit2 submodule to 1.2.0 #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the recent release of 1.2.0
ehuss
reviewed
Sep 3, 2021
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "libgit2-sys" | |||
| version = "0.12.22+1.1.0" | |||
| version = "0.12.22+1.2.0" | |||
There was a problem hiding this comment.
I think the version needs to be bumped to 23 there since otherwise cargo ignores the metadata.
There was a problem hiding this comment.
Oh ooops I forgot I left this PR here. I didn't see anything too too serious in terms of security in the release notes so I wasn't planning on releasing this immediately. I just wanted to bump this to make sure that in the future when the crate version is bumped the build metadata is still accurate.
|
@alexcrichton can we actually push this to a release. It make some people happy to have a git2-rs release that works with an official libgit2 release again :) |
|
Sure! If you could send a PR for the bumps that'd be great, then I could hit the publish button |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the recent release of 1.2.0