Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

Drop kennytm from CI review #416

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Drop kennytm from CI review #416

merged 1 commit into from
Aug 1, 2022

Conversation

Mark-Simulacrum
Copy link
Member

No description provided.

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also drop kenny from the libs review queue? not sure how active they've been there ...

@Mark-Simulacrum
Copy link
Member Author

I think this change definitely makes sense (and it may make sense to add you), libs PR queue already moves pretty slowly in general and there is some activity there so I'm not sure it makes sense to drop at this time.

@Mark-Simulacrum Mark-Simulacrum merged commit ed451a1 into master Aug 1, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the updates branch August 1, 2022 00:22
@jyn514
Copy link
Member

jyn514 commented Aug 1, 2022

and it may make sense to add you

sure, done :) #417

@thomcc
Copy link
Member

thomcc commented Aug 8, 2022

Should we also drop kenny from the libs review queue? not sure how active they've been there ...

Pretty inactive, so IMO yes. As it is, I end up looking over their review list every so often and taking things if they haven't gotten attention, it would really be much better if they were just not put there in the first place (since "has this gotten attention" isn't the same as "is someone who can eventually r+ it looking at it").

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants