Skip to content

Re-enable semver check #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 5, 2020
Merged

Re-enable semver check #1667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fba8b18
Re-enable semver check
JohnTitor Feb 20, 2020
37967b3
Use semververfork
JohnTitor Mar 4, 2020
f83c97e
Update lint name
JohnTitor Mar 4, 2020
b52e8e0
Fix shellcheck warning
JohnTitor Mar 4, 2020
2c73dd9
Add `rustc-dev` component
JohnTitor Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions ci/azure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,26 +136,25 @@ jobs:
parameters:
deploy_dir: target/doc

# FIXME: re-enable these after the next release
#- job: SemverLinux
# dependsOn: BuildChannelsLinux
# continueOnError: true
# pool:
# vmImage: ubuntu-18.04
# steps:
# - template: azure-install-rust.yml
# - script: sh ci/semver.sh linux
# displayName: Check breaking changes
- job: SemverLinux
dependsOn: BuildChannelsLinux
continueOnError: true
pool:
vmImage: ubuntu-18.04
steps:
- template: azure-install-rust.yml
- script: sh ci/semver.sh linux
displayName: Check breaking changes

#- job: SemverOSX
# dependsOn: BuildChannelsOSX
# continueOnError: true
# pool:
# vmImage: macos-10.15
# steps:
# - template: azure-install-rust.yml
# - script: sh ci/semver.sh osx
# displayName: Check breaking changes
- job: SemverOSX
dependsOn: BuildChannelsOSX
continueOnError: true
pool:
vmImage: macos-10.15
steps:
- template: azure-install-rust.yml
- script: sh ci/semver.sh osx
displayName: Check breaking changes

- job: BuildChannelsLinux
dependsOn: StyleAndDocs
Expand Down
8 changes: 6 additions & 2 deletions ci/semver.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ if ! rustc --version | grep -E "nightly" ; then
exit 1
fi

cargo +nightly install semverver
rustup component add rustc-dev

# FIXME: Use upstream once it gets rustup.
cargo +nightly install semververfork

TARGETS=
case "${OS}" in
Expand Down Expand Up @@ -73,5 +76,6 @@ for TARGET in $TARGETS; do
sleep 1
done

cargo +nightly semver --api-guidelines --target="${TARGET}"
# FIXME: Use upstream once it gets rustup.
cargo +nightly semverfork --api-guidelines --target="${TARGET}"
done
2 changes: 1 addition & 1 deletion ci/style.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -ex
rustc ci/style.rs && ./style src

if rustup component add rustfmt-preview ; then
which rustfmt
command -v rustfmt
rustfmt -V
cargo fmt --all -- --check
fi
Expand Down
7 changes: 5 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,17 @@
//! [pd]: https://rust-lang.github.io/libc/#platform-specific-documentation
#![crate_name = "libc"]
#![crate_type = "rlib"]
#![cfg_attr(libc_deny_warnings, deny(warnings))]
// FIXME: Remove this and redundant_semicolon once renamed lint reaches stable.
#![allow(renamed_and_removed_lints)]
#![allow(
bad_style,
overflowing_literals,
improper_ctypes,
unknown_lints,
redundant_semicolon
redundant_semicolon,
redundant_semicolons
)]
#![cfg_attr(libc_deny_warnings, deny(warnings))]
// Attributes needed when building as part of the standard library
#![cfg_attr(
feature = "rustc-dep-of-std",
Expand Down