Skip to content

Create macros for defining Copy/Clone on enums and struct(), use for psp #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

MrAwesome
Copy link
Contributor

I tried to keep the macros simple and just define the basic things needed, happy to modify them in whatever way feels best.

Tested this by compiling and running a psp EBOOT.PBP including stdlib, so I'm pretty certain this at least isn't introducing anything catastrophic. I noticed we don't have any entries in libc-test, and neither does switch. Is that something I should add? Not sure what it would look like but I'm happy to crib it from another type if it makes sense.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

Overall looks good to me! Could you fix the style issue that CI reports? It blocks the test for this target.

I noticed we don't have any entries in libc-test, and neither does switch. Is that something I should add? Not sure what it would look like but I'm happy to crib it from another type if it makes sense.

Certainly we don't have it but we do test the build here: https://github.com/rust-lang/libc/blob/master/ci/build.sh

We don't because libc-test (i.e. run.sh) needs a virtual environment (see other platforms for an example) and I'm not familiar with the targets. If you want to go ahead, I'm happy to review and accept it :)

@JohnTitor
Copy link
Member

Okay, now CI is green! Could you squash commits? r=me once it's done.

@MrAwesome MrAwesome force-pushed the psp_copy_clone_macros branch from 6ed05be to 2d5fc45 Compare July 27, 2020 20:52
@MrAwesome
Copy link
Contributor Author

r? @JohnTitor

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor merged commit fb6a306 into rust-lang:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants