Skip to content

Define CLD_ constants for more targets #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Define CLD_ constants for more targets #2004

merged 1 commit into from
Dec 24, 2020

Conversation

dylni
Copy link
Contributor

@dylni dylni commented Dec 22, 2020

This is an extension of #1860 to support more targets. The values for these constants should be correct, but I'm not familiar with most of the targets, so they should be verified.

These files should define the constants too, but the targets are closed source, so I don't know their values:

@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 24, 2020

📌 Commit d116ee5 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Dec 24, 2020

⌛ Testing commit d116ee5 with merge 6e7a919...

@bors
Copy link
Contributor

bors commented Dec 24, 2020

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 6e7a919 to master...

@bors bors merged commit 6e7a919 into rust-lang:master Dec 24, 2020
@bors bors mentioned this pull request Dec 24, 2020
1 task
@dylni
Copy link
Contributor Author

dylni commented Dec 24, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants