-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Define basic Linux SocketCAN constants and types #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left some comments.
Also, it'd be great if you could squash commits into one. |
Squashed the commits. |
Thanks! |
📌 Commit 5449cae has been approved by |
Define basic Linux SocketCAN constants and types Add definitions from `linux/can.h`, which is a "base" header for remainder of SocketCAN functionality. CAN bus (ISO-11898) is a communication standard used in automotive, automation and industrial solutions. Linux provides a socket-like interface to access raw CAN and protocols based on CAN, such as ISO-TP(ISO-15765) or SAE-J1939.
💔 Test failed - checks-actions |
CI failed:
That target's CI stuff is old (since |
Looks like J1939 was added in Linux 5.4, not sure what version of kernel headers that target has. |
Let's skip the tests for now, we could tweak here: Line 2595 in 9d6d018
Add this with FIXME comment: "CAN_J1939" if mips => true, |
@bors r+ |
📌 Commit 86eb6c1 has been approved by |
Define basic Linux SocketCAN constants and types Add definitions from `linux/can.h`, which is a "base" header for remainder of SocketCAN functionality. CAN bus (ISO-11898) is a communication standard used in automotive, automation and industrial solutions. Linux provides a socket-like interface to access raw CAN and protocols based on CAN, such as ISO-TP(ISO-15765) or SAE-J1939.
💔 Test failed - checks-actions |
@bors r+ |
📌 Commit e18dc03 has been approved by |
Define basic Linux SocketCAN constants and types Add definitions from `linux/can.h`, which is a "base" header for remainder of SocketCAN functionality. CAN bus (ISO-11898) is a communication standard used in automotive, automation and industrial solutions. Linux provides a socket-like interface to access raw CAN and protocols based on CAN, such as ISO-TP(ISO-15765) or SAE-J1939.
💔 Test failed - checks-actions |
@bors r+ |
📌 Commit a39cf0d has been approved by |
Define basic Linux SocketCAN constants and types Add definitions from `linux/can.h`, which is a "base" header for remainder of SocketCAN functionality. CAN bus (ISO-11898) is a communication standard used in automotive, automation and industrial solutions. Linux provides a socket-like interface to access raw CAN and protocols based on CAN, such as ISO-TP(ISO-15765) or SAE-J1939.
💔 Test failed - checks-actions |
@bors r+ |
📌 Commit 66500ee has been approved by |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Add definitions from
linux/can.h
, which is a "base" header for remainder of SocketCAN functionality.CAN bus (ISO-11898) is a communication standard used in automotive, automation and industrial solutions. Linux provides a socket-like interface to access raw CAN and protocols based on CAN, such as ISO-TP(ISO-15765) or SAE-J1939.