Skip to content

Add NETLINK_EXT_ACK and NETLINK_GET_STRICT_CHK on Linux #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

Add NETLINK_EXT_ACK and NETLINK_GET_STRICT_CHK on Linux #2453

merged 1 commit into from
Oct 22, 2021

Conversation

tklauser
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Oct 15, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 15, 2021

📌 Commit 110aea3 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Oct 15, 2021

⌛ Testing commit 110aea3 with merge 2582208...

bors added a commit that referenced this pull request Oct 15, 2021
@bors
Auto merge of #2453 - tklauser:linux-netlink-consts, r=Amanieu
2582208 
Add NETLINK_EXT_ACK and NETLINK_GET_STRICT_CHK on Linux
@bors
Copy link
Contributor

bors commented Oct 15, 2021

💔 Test failed - checks-actions

@tklauser tklauser force-pushed the linux-netlink-consts branch from 110aea3 to b23c1cf Compare October 16, 2021 14:06
@tklauser
Copy link
Contributor Author

NETLINK_GET_STRICT_CHK does not seem to be available in headers on ARM and MIPS. I've skipped these in tests.

@Amanieu could you please re-trigger the tests?

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2021

📌 Commit b23c1cf has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Oct 20, 2021

⌛ Testing commit b23c1cf with merge 496d063...

bors added a commit that referenced this pull request Oct 20, 2021
@bors
Auto merge of #2453 - tklauser:linux-netlink-consts, r=JohnTitor
496d063 
Add NETLINK_EXT_ACK and NETLINK_GET_STRICT_CHK on Linux
@bors
Copy link
Contributor

bors commented Oct 20, 2021

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

I think the musl kernel version on CI is old?

@bors
Copy link
Contributor

bors commented Oct 21, 2021

☔ The latest upstream changes (presumably #2471) made this pull request unmergeable. Please resolve the merge conflicts.

@tklauser tklauser force-pushed the linux-netlink-consts branch from b23c1cf to 2c65744 Compare October 21, 2021 22:42
@tklauser
Copy link
Contributor Author

I think the musl kernel version on CI is old?

Thanks, looks like it. Changed the test to skip on musl as well. Also rebased to resolve merge conflicts.

@JohnTitor
Copy link
Member

👍, @bors r+

@bors
Copy link
Contributor

bors commented Oct 21, 2021

📌 Commit 2c65744 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Oct 21, 2021

⌛ Testing commit 2c65744 with merge 77636bb...

@bors
Copy link
Contributor

bors commented Oct 22, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 77636bb to master...

@bors bors merged commit 77636bb into rust-lang:master Oct 22, 2021
@tklauser tklauser deleted the linux-netlink-consts branch October 22, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tklauser @rust-highfive @Amanieu @bors @JohnTitor