Avoid usage of thread_local on DragonFlyBSD #3653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
JohnTitor
reviewed
Apr 16, 2024
bjorn3
force-pushed
the
dragonfly_no_thread_local
branch
from
64bd72c to
1ab93fb
Compare
__error() has been deprecated and return the same value as __errno_location(). Removing the __error() function eliminates the sole use of thread_local in this crate.
bjorn3
force-pushed
the
dragonfly_no_thread_local
branch
from
1ab93fb to
de76fee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both __errno_location() and __error() return the same value, so the __error() function can be implemented on the Rust side as __errno_location(). This eliminates the sole use of thread_local in this crate.