chore: lint libc-test/build.rs
#4412
Merged
+59
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
stable-nominated
nyurik
force-pushed
the
libc-test-lints
branch
7 times, most recently
from
51658d2 to
4accf8f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
nyurik
force-pushed
the
libc-test-lints
branch
2 times, most recently
from
20de9a7 to
e679015
Compare
tgross35
requested changes
Apr 16, 2025
tgross35
requested changes
Apr 25, 2025
libc-test/build.rs
Outdated
Comment on lines
3577
to
3578
| cfg.skip_type(move |ty| match ty { | ||
| "stat64" | "sighandler_t" | "off64_t" => true, | ||
| _ => false, | ||
| }); | ||
| cfg.skip_type(|ty| matches!(ty, "stat64" | "sighandler_t" | "off64_t")); | ||
|
|
||
| cfg.skip_field_type(move |struct_, field| match (struct_, field) { | ||
| ("siginfo_t", "si_value") | ("stat", "st_size") | ("sigaction", "sa_u") => true, | ||
| _ => false, | ||
| cfg.skip_field_type(|struct_, field| { | ||
| matches!( | ||
| (struct_, field), | ||
| ("siginfo_t", "si_value") | ("stat", "st_size") | ("sigaction", "sa_u") | ||
| ) |
There was a problem hiding this comment.
Could you drop the changes to matches! here? It's easier and less conflict-y to append new types/fields in the current form, plus consistency.
|
thx, fixed |
run `cargo clippy --all-targets` on `libc-test/build.rs`, and fix all default issues. ### Notes * `copy_dir_hotfix` had a `replace` parameter that was never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run
cargo clippy --all-targetsonlibc-test/build.rs, and fix all default issues.Notes
copy_dir_hotfixhad areplaceparameter that was never used@rustbot label +stable-nominated