chore: lint ctest-test crate

[nyurik]

run cargo clippy --all-targets on ctest-test, and fix all default issues

@rustbot label +stable-nominated

[rustbot]

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[tgross35]

Side note, ctest isn't on the libc-0.2 branch at all so there are no backports needed for these changes.

[tgross35]

LGTM, please squash

[nyurik]

thx, done. Why isn't libc using the github squash command?

[tgross35]

Thanks!

Annoyingly with merge queues you can't choose the strategy on a case-by-case basis, and we do need to preserve commits in some cases. Sometimes I can squash and force push via the gh UI, but better if the author can do it so they don't get out of sync.

I can use rebase from the UI if something gets stuck on since-fixed tests though, case in point.