Skip to content

Added monospace font with support for box-drawing chars #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2017
Merged

Added monospace font with support for box-drawing chars #250

merged 1 commit into from
Apr 15, 2017

Conversation

regexident
Copy link
Contributor

Even Github seams to not be capable of properly showing curses-style box-drawing characters:

  ╭────────────────────╮
╭→│ boxes are awesome! ├─╮
│ ╰────────────────────╯ │
╰────────────────────────╯

With this PR mdBook would be ($ cargo doc does support them, too!).

@azerupi
Copy link
Contributor

azerupi commented Apr 14, 2017

Looks cool!
Two nitpicks though :)

  1. The font looks much bigger than before. Is it possible to tweak the font-size so that it stays roughly the same size? Ideally we should check for every back-up font that it looks ok at that size.
  2. Could you modify the stylus files and regenerate the css, instead of editing the css file directly? Because changes in the css file will be overwritten on the next regeneration.

@regexident
Copy link
Contributor Author

  1. The font looks much bigger than before. Is it possible to tweak the font-size so that it stays roughly the same size? Ideally we should check for every back-up font that it looks ok at that size.

Apple's "Menlo" and Ubuntu's "DejaVu Sans Mono" are both based on "Vera Sans Mono". As such they are near-identical in general appearance and size, while "Source Code Pro" has a slightly taller line-height.

There is font-size-adjust, but unfortunately it's only supported by Firefox right now. However adding font-size: 0.875em; should do the trick, I think, bringing the font-size down roughly to where it was before (on my machine's Chrome, at least).

  1. Could you modify the stylus files and regenerate the css, instead of editing the css file directly? Because changes in the css file will be overwritten on the next regeneration.

Oh, I missed that step. Done.

@azerupi azerupi merged commit b5ec813 into rust-lang:master Apr 15, 2017
@azerupi
Copy link
Contributor

azerupi commented Apr 15, 2017

Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants