Skip to content

Merge 'master' into 'rust-pr-46952' #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Merge 'master' into 'rust-pr-46952' #55

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79d7569
Clarify "unsafe pollutes the module"
SimonSapin Dec 24, 2017
2f7b05f
Merge pull request #50 from SimonSapin/patch-2
Gankra Dec 24, 2017
fec3182
Merge remote-tracking branch 'upstream/master' into rust-pr-46952
SimonSapin Jan 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/working-with-unsafe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ capacity violates the invariants of Vec (that `cap` reflects the allocated space
in the Vec). This is not something the rest of Vec can guard against. It *has*
to trust the capacity field because there's no way to verify it.

`unsafe` does more than pollute a whole function: it pollutes a whole *module*.
Because it relies on invariants of a struct field, this `unsafe` code
does more than pollute a whole function: it pollutes a whole *module*.
Generally, the only bullet-proof way to limit the scope of unsafe code is at the
module boundary with privacy.

Expand Down