-
Notifications
You must be signed in to change notification settings - Fork 290
Test and fix to vec-final #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed Iterator implementation for Drain Added some tests to code
@steveklabnik - I think I get it with tests - mdbook is running doctests only - so I modify code bit to run tests as doctests - also tests are now hidden, as main function is hidden too, so they do not appear in book - to make final example clearer. |
@izderadicka so you verified that the tests are now run by |
src/vec-final.md
Outdated
# for i in v.iter_mut() { | ||
# *i += 1; | ||
# } | ||
# v.insert(0, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe insert a different value here so we can distinguish them, making sure the right one gets indeed popped?
@RalfJung - Yes test are running now - as doctest is running |
LGTM except for changing |
@RalfJung - changed test as required |
Fixed Iterator implementation for Drain
Added some tests to code
@RalfJung - as discussed in #71 I've created separate PR for these two changes
@steveklabnik - in #71 you noted that test should run during
mdbook test
, but it does not seem to be so (if I modify a test to fail nothing happens) - is there anything else needed for tests to run?