-
Notifications
You must be signed in to change notification settings - Fork 532
Divide items and expressions into sections #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@steveklabnik @QuietMisdreavus @GuillaumeGomez @frewsxcv This is a relatively major structural change. I'm not sure how to do the checkbox thingy - so, are you all good with this change? I think it's a good change personally. |
Sounds good to me, though I have a feeling we'll need to update links in the Rust repository as well, maybe also nomicon |
c866a13
to
8000318
Compare
A
I didn't find any links on nomicon and rust-by-example. |
We need coordination with the stdlib docs to update things properly. I don't know how to do the coordination required here. |
The approach is to merge this first, then bump the git submodule in rust-lang/rust in a follow-up PR. @brauliobz FYI, looks like there's merge conflicts here |
- Links in other parts of the reference were updated - The following sections were moved inside others: * grouped expressions into operator-expr.md * while let into loop-expr.md * if let into if-expr.md * tuple indexing into tuple-expr.md
8000318
to
ae361e1
Compare
Yup, going to do that right now. Thanks! |
FWIW this also did break inter-reference stuff:
I'm fixing it though 😄 |
Thanks! |
Thanks for improving the reference; this kind of stuff is *so* needed :)
…On Mon, Oct 2, 2017 at 12:11 PM, Bráulio Bezerra ***@***.***> wrote:
I'm fixing it though 😄
Thanks!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABsisi1Gqx0If7LarYOei0Bu01wZsHXks5soQsbgaJpZM4O6QXL>
.
|
Rendered
To concat
items.md
for comparison purposes:cat src/items.md src/items/{modules,extern-crates,use-declarations,functions,type-aliases,structs,enumerations,unions,constant-items,static-items,traits,implementations,external-blocks}.md > src/items.new.md
expressions.md
for comparison purposes:cat src/expressions.md src/expressions/{literal-expr,path-expr,tuple-expr,struct-expr,enum-variant-expr,block-expr,method-call-expr,field-expr,call-expr,closure-expr,array-expr,range-expr,operator-expr,loop-expr,if-expr,match-expr,return-expr}.md > src/expressions.new.md
The following sections were moved inside others and won't match in the diff above: grouped expressions, while let, if let, tuple indexing.
I (hopefully) fixed all affected links.