Attributes in generics position and general attributes improvements #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/items/generics.md
Outdated
| > **<sup>Syntax</sup>** | ||
| > _WhereClause_ : | ||
| > **<sup>Syntax</sup>** | ||
| > _WhereClause_ : |
There was a problem hiding this comment.
These spaces are needed for line breaks. They could be replaced with <br>s if you prefer.
There was a problem hiding this comment.
<br>s would be even more noisy. I'll just revert the removal.
| (C#). An attribute is a general, free-form metadatum that is interpreted | ||
| according to name, convention, and language and compiler version. Attributes | ||
| may appear as any of: | ||
| Any [item declaration] or [generic lifetime or type parameter][generics] may |
There was a problem hiding this comment.
Actually, this is a lot more complicated, because also enum variants, struct and union fields, match arms...
Havvy
force-pushed
the
attr-in-type-param-position
branch
from
0599dd0 to
c363127
Compare
|
|
Havvy
force-pushed
the
attr-in-type-param-position
branch
from
c363127 to
56b9cb2
Compare
|
I retract the previous comment. I've removed the extra commits, and will be working on them in a separate PR. This includes adding the other places that attributes can be found. |
Havvy
force-pushed
the
attr-in-type-param-position
branch
from
56b9cb2 to
05b0a98
Compare
Havvy
force-pushed
the
attr-in-type-param-position
branch
from
05b0a98 to
3136dca
Compare
matthewjasper
approved these changes
Jun 4, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes in generics is stabilized in 1.27 as per rust-lang/rust#48851.
I moved the defining italics for attributes to the actual definition and gave inner/outer attributes actual definition lines instead of leaving it implied.
There's also a few newlines for 80 character style and removing trailing spaces in here.