-
Notifications
You must be signed in to change notification settings - Fork 461
Add a onepass dfa matcher. #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
850077d
Add function to determine if a regex is onepass.
3669881
Add a onepass DFA.
b6fab61
Add doc comment to is_onepass
5ff7c80
rewrite NestedConcat to avoid stack space usage liniear in the size o…
6355ce5
refactor is_onepass to be part of Hir construction.
6ec93a6
Revert "refactor is_onepass to be part of Hir construction."
b5b8f82
switch is_onepass to direct recursion instead of visitor.
b31e36f
remove one allocation per instruction by directly mutating state_edge
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -797,6 +797,16 @@ impl ClassUnicode { | |
pub fn symmetric_difference(&mut self, other: &ClassUnicode) { | ||
self.set.symmetric_difference(&other.set); | ||
} | ||
|
||
/// Returns true iff this character class contains no characters. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same typo. |
||
/// | ||
/// This should never be true for a character class which was | ||
/// constructed by the regex parser, but a notion of character | ||
/// class emptiness can be useful for code that wants to | ||
/// programmatically generate character classes. | ||
pub fn is_empty(&self) -> bool { | ||
self.set.is_empty() | ||
} | ||
} | ||
|
||
/// An iterator over all ranges in a Unicode character class. | ||
|
@@ -998,6 +1008,16 @@ impl ClassBytes { | |
pub fn is_all_ascii(&self) -> bool { | ||
self.set.intervals().last().map_or(true, |r| r.end <= 0x7F) | ||
} | ||
|
||
/// Returns true iff this character class contains no characters. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same (probably copy-paste). |
||
/// | ||
/// This should never be true for a character class which was | ||
/// constructed by the regex parser, but a notion of character | ||
/// class emptiness can be useful for code that wants to | ||
/// programmatically generate character classes. | ||
pub fn is_empty(&self) -> bool { | ||
self.set.is_empty() | ||
} | ||
} | ||
|
||
/// An iterator over all ranges in a byte character class. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo:
if
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a typo.
iff
is parlance for "if and only if."