Rust 2018 README updates #552
Conversation
I'm not sure there's that much friction, especially given that current examples are compatible and work in both editions out of the box, while removing |
|
@RReverser can understand your viewpoint but just checking out Rust since 2018 release myself I've found it confusing stumbling across this syntax before being 100% on how it worked. I had put it in some places and not others until I got far enough along on my learning to revisit the 2018 notes. EDIT: I just think for the top 20 odd crates it's worthwhile having it in sync with "the book" to limit confusion, especially with Rust having a smaller std lib and programmers from other languages taking stuff like regex as part of their standard toolset without using dependencies usually |
This updates the README examples to drop the use of `extern crate`. We do include instructions to add it, but only for Rust 2015. Closes #552
Making the example use 2018 behaviour the default.
Here are the changes working in the playground (note 2018 selected):
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=931cef3284f7178eb62554da4a2c035b
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=aaf7f7a741bae6f15de710a16a7340ed
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=619ddc6c95a9a02bd94fd9e19d22c445
Other top 20 crates are updating as well so this is to fall in line. Didn't mention 2015 compatibility as this has largely been ignored elsewhere (except in log crate), with the assumption that anyone on older versions of Rust will know the extern crate syntax.
Having the default 2018 changes in means less friction for new Rustaceans, a lot of whom will only have adopted it post 2018 introduction.
FYI, I can update to include some sort of nod to 2015 if there is a need from the maintainers 👍
Lastly, I noticed docs.rs will still use older syntax. Not sure whether this should be addressed as well. Let me know on merge and I can look into it.