Skip to content

add explicit error for \ as unicode class #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add explicit error for \ as unicode class #622

wants to merge 1 commit into from

Conversation

danieledapo
Copy link
Contributor

this should close #594 by adding a new ErrorKind variant that should hopefully improve diagnostics.

@danieledapo
Copy link
Contributor Author

I'm not quite sure why only one job is failing, but I think it has nothing to do with my changes. I suspect rustfmt got updated in the meanwhile and now it wants to reformat things differently, but I've not double checked that.

BurntSushi pushed a commit that referenced this pull request Jan 9, 2020
@BurntSushi BurntSushi closed this in eff5348 Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\p\ interacts poorly with error reporting
1 participant