Skip to content

Human friendly incantations + Auto Closing/Postponing RFCs + More labels #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 30, 2018
Merged

Human friendly incantations + Auto Closing/Postponing RFCs + More labels #197

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a330887
improve rfcbot command parsing to be more human friendly.
Centril Apr 20, 2018
e347795
refactor + auto-close/postpone FFCPed RFCs + better FFCP comment + mo…
Centril Apr 20, 2018
6295b0e
update toolchain := 2018-04-19 + cargo update
Centril Apr 20, 2018
544d05e
refactor consts into a Label enum.
Centril Apr 20, 2018
2a96c07
add/remove_label methods on Issue instead of free functions.
Centril Apr 21, 2018
dac6c55
fix the GH.close_issue command.
Centril Apr 21, 2018
13c38fd
FCP + concern => PFCP per aturon's request; also refactor into execut…
Centril Apr 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/github/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,25 @@ impl Client {
None
}

pub fn close_pr(&self, repo: &str, issue_num: i32) -> DashResult<()> {
let url = format!("{}/repos/{}/pulls/{}", BASE_URL, repo, issue_num);

let mut obj = BTreeMap::new();
obj.insert("status", "closed");
let payload = serde_json::to_string(&obj)?;

let mut res = self.patch(&url, &payload)?;

match res.status {
StatusCode::Ok => Ok(()),
_ => {
let mut body = String::new();
res.read_to_string(&mut body)?;
Err(DashError::Misc(Some(body)))
}
}
}

pub fn add_label(&self, repo: &str, issue_num: i32, label: &str) -> DashResult<()> {
let url = format!("{}/repos/{}/issues/{}/labels", BASE_URL, repo, issue_num);
let payload = serde_json::to_string(&[label])?;
Expand Down
Loading