Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Version numbers are confusing #1239

Closed
ehuss opened this issue Jan 17, 2019 · 4 comments
Closed

Version numbers are confusing #1239

ehuss opened this issue Jan 17, 2019 · 4 comments

Comments

@ehuss
Copy link
Contributor

ehuss commented Jan 17, 2019

The version number seems to have gone backwards in 1.32:

rustc Version RLS Version
1.30.0 rls-preview 0.130.5-stable (2b21611 2018-09-15)
1.31.0 rls-preview 1.31.6 (6610526 2018-12-01)
1.31.1 rls-preview 1.31.7 (da98b4d 2018-12-18)
1.32.0 rls-preview 1.31.6 (bfa1371 2018-12-07)
1.33.0-nightly (2fadb0a16 2019-01-13) rls-preview 1.31.6 (1a6361b 2019-01-04)

Is it intended to follow the rustc version?

@Xanewok
Copy link
Member

Xanewok commented Jan 17, 2019

1.31.1 is the odd one out - it's on a stable backport branch (hence the date mismatch), and it contains only da98b4d and 8c0c7dc on top of bfa1371 needed at the time but the point release going back to 6 is not good...

@pietroalbini is it worth doing the backport now just to fix the point release number in 1.32?
cc @nrc

@pietroalbini
Copy link
Member

I'd say no, considering the release is in a few hours max.
cc @rust-lang/release

@nrc
Copy link
Member

nrc commented Jan 18, 2019

yeah, I don't think it is work a point release, but lets make sure we push something to beta and nightly so those numbers are correct

@Xanewok Xanewok pinned this issue Jan 18, 2019
bors added a commit to rust-lang/rust that referenced this issue Jan 21, 2019
beta: Update RLS version to 1.33

We missed the 1.32 stable release for version bump, let's make it less confusing and backport a version bump for the current 1.33 beta.

rust-lang/rls#1239

r? @pietroalbini

cc @nrc
@Xanewok
Copy link
Member

Xanewok commented Mar 3, 2019

Recent stable is 1.33 which should contain RLS with version 1.33.

@Xanewok Xanewok closed this as completed Mar 3, 2019
@Xanewok Xanewok unpinned this issue Mar 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants