Skip to content

editor/code: Enable TypeScript's --exactOptionalPropertyTypes #15253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tetsuharuohzeki opened this issue Jul 10, 2023 · 0 comments
Open

editor/code: Enable TypeScript's --exactOptionalPropertyTypes #15253

tetsuharuohzeki opened this issue Jul 10, 2023 · 0 comments
Labels
A-vscode vscode plugin issues C-enhancement Category: enhancement

Comments

@tetsuharuohzeki
Copy link
Contributor

This issue proposes to enable TS' --exactOptionalPropertyTypes option.

To enable this option,

  • npm:@types/vscode chages their optional property types to accept undefined (e.g. bar?: Foo should be bar?: Foo | undefined if there is no problem).
  • Or we need to change our code to avoid to assign undefined to properties as marked as optional.
@tetsuharuohzeki tetsuharuohzeki mentioned this issue Jul 10, 2023
Merged
bors added a commit that referenced this issue Jul 10, 2023
@bors
Auto merge of #15254 - tetsuharuohzeki:add-fixme-exactOptionalPropert…
785a33d 
…yTypes, r=lnicola

editor/code: Add FIXME comments for TS' `--exactOptionalPropertyTypes` option

This add the FIXME comment for  #15253
@lowr lowr added A-vscode vscode plugin issues C-enhancement Category: enhancement labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-vscode vscode plugin issues C-enhancement Category: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tetsuharuohzeki @lowr