Assists which always generate a snippet regardless of snippet capability #17332
Labels
Comments
bors
added a commit
that referenced
this issue
Jun 3, 2024
…=Veykril fix: Only generate snippets for `extract_expressions_from_format_string` if snippets are supported Part of #17332 Fixes `extract_expressions_from_format_string` so that it doesn't generate snippets if the client doesn't support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These assists always generate a snippet regardless of if the LSP client does or doesn't support the snippet text edit capability:
extract_expressions_from_format_stringfix: Only generate snippets forextract_expressions_from_format_stringif snippets are supported #17333generate_constantgenerate_mut_trait_implThey unfortunately weren't captured in the initial batch of migrations to the new structured snippet API as they didn't use
{insert,replace}_snippet, which is what I used to figure out which assists needed migrating.Note that because the structured snippet API (
add_{tabstop,placeholder}_*) relies on syntax nodes, they must also be migrated away from usinginsertandreplace.The text was updated successfully, but these errors were encountered: