Skip to content

RA nightly starting from v0.4.2130 doesn't show method signatures in completion popup window #18231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahlinc opened this issue Oct 4, 2024 · 0 comments · Fixed by #18245
Closed

RA nightly starting from v0.4.2130 doesn't show method signatures in completion popup window #18231

ahlinc opened this issue Oct 4, 2024 · 0 comments · Fixed by #18245
Labels
A-completion autocompletion Broken Window Bugs / technical debt to be addressed immediately

Comments

@ahlinc
Copy link
Contributor

ahlinc commented Oct 4, 2024

The right side like on the screenshot bellow isn't shown in completions pop up window starting from v0.4.2130 nightly version, the last good was v0.4.2128.

Image

Current situation on latest v0.4.2133:

Image
@ahlinc ahlinc added the Broken Window Bugs / technical debt to be addressed immediately label Oct 4, 2024
@ahlinc ahlinc changed the title RA nightly starting from v0.4.2130 don't show method signatures in completion popup window RA nightly starting from v0.4.2130 doesn't show method signatures in completion popup window Oct 4, 2024
@ShoyuVanilla ShoyuVanilla added the A-completion autocompletion label Oct 4, 2024
@boattime boattime mentioned this issue Oct 5, 2024
Merged
@bors bors closed this as completed in 0fb804a Oct 9, 2024
lnicola pushed a commit to lnicola/rust that referenced this issue Oct 17, 2024
@bors
Auto merge of rust-lang#18245 - boattime:master, r=davidbarsky
ee7c8b9 
fix: include description in label details when detail field is marked for …

Fixes rust-lang/rust-analyzer#18231.

When omitting the autocomplete detail field, the autocomplete label details can still be returned. Currently the label details are missing the description field if the detail field is included in resolveSupport since it is being overwritten as None and opted to be sent with `completionItem/resolve`.

Example completion capabilities.
```
completion = {
    completionItem = {
        commitCharactersSupport = true,
        deprecatedSupport = true,
        documentationFormat = { "markdown", "plaintext" },
        insertReplaceSupport = true,
        insertTextModeSupport = {
            valueSet = { 1, 2 }
        },
        labelDetailsSupport = true,
        preselectSupport = true,
        resolveSupport = {
            properties = { "documentation", "detail", "additionalTextEdits", "sortText", "filterText", "insertText", "textEdit", "insertTextFormat", "insertTextMode" }
        },
        snippetSupport = true,
        tagSupport = {
            valueSet = { 1 }
        }
}
```
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Nov 9, 2024
@bors
Auto merge of #18245 - boattime:master, r=davidbarsky
8c2b501 
fix: include description in label details when detail field is marked for …

Fixes rust-lang/rust-analyzer#18231.

When omitting the autocomplete detail field, the autocomplete label details can still be returned. Currently the label details are missing the description field if the detail field is included in resolveSupport since it is being overwritten as None and opted to be sent with `completionItem/resolve`.

Example completion capabilities.
```
completion = {
    completionItem = {
        commitCharactersSupport = true,
        deprecatedSupport = true,
        documentationFormat = { "markdown", "plaintext" },
        insertReplaceSupport = true,
        insertTextModeSupport = {
            valueSet = { 1, 2 }
        },
        labelDetailsSupport = true,
        preselectSupport = true,
        resolveSupport = {
            properties = { "documentation", "detail", "additionalTextEdits", "sortText", "filterText", "insertText", "textEdit", "insertTextFormat", "insertTextMode" }
        },
        snippetSupport = true,
        tagSupport = {
            valueSet = { 1 }
        }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-completion autocompletion Broken Window Bugs / technical debt to be addressed immediately
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include description in label details when detail field is marked for … boattime/rust-analyzer
2 participants
@ShoyuVanilla @ahlinc