-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Simplify server reloading logic #3164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yeah, this was my initial proposal, though you gave an argument that we don't cancel inflight requests (already scheduled microtasks that hold a reference to terminated language client). |
One way to better employ the solution you referenced here with more confidence is to await for the resolution of all microtasks before restarting the server... |
FYI: as an example of flushing microtasks implementation we can refer to this implementation in jest testing framework that is added in testing-library/react-testing-library#440 |
3190: Simplify TS reload logic r=matklad a=matklad Fixes #3164 Co-authored-by: Aleksey Kladov <[email protected]>
3190: Simplify TS reload logic r=matklad a=matklad Fixes #3164 Co-authored-by: Aleksey Kladov <[email protected]>
3190: Simplify TS reload logic r=matklad a=matklad Fixes #3164 Co-authored-by: Aleksey Kladov <[email protected]>
freebsd adding getrandom interception. note that os support was added in same time as getentropy.
freebsd adding getrandom interception. note that os support was added in same time as getentropy.
microsoft/vscode#45774 (comment) <- seems much neater way then what we are doing
The text was updated successfully, but these errors were encountered: