Skip to content

Assist: replace string with char #6252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matklad opened this issue Oct 16, 2020 · 0 comments · Fixed by #6256
Closed

Assist: replace string with char #6252

matklad opened this issue Oct 16, 2020 · 0 comments · Fixed by #6256
Labels
E-easy E-has-instructions Issue has some instructions and pointers to code to get started good first issue S-actionable Someone could pick this issue up and work on it right now

Comments

@matklad
Copy link
Member

matklad commented Oct 16, 2020 

find("}")
==>>
find('}')

See https://github.com/rust-analyzer/rust-analyzer/blob/4271e4c703d8d764a1d6ffdc501a6cea2157f9d1/crates/assists/src/handlers/raw_string.rs for a similar assist.
@matklad matklad added good first issue E-easy E-has-instructions Issue has some instructions and pointers to code to get started S-actionable Someone could pick this issue up and work on it right now labels Oct 16, 2020
bnjjj added a commit to bnjjj/rust-analyzer that referenced this issue Oct 16, 2020
@bnjjj
replace_string_with_char rust-lang#6252
62192ce 
Signed-off-by: Benjamin Coenen <[email protected]>
@bnjjj bnjjj mentioned this issue Oct 16, 2020
Merged
@bors bors bot closed this as completed in c003395 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy E-has-instructions Issue has some instructions and pointers to code to get started good first issue S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assist: replace string with char bnjjj/rust-analyzer
1 participant
@matklad