Skip to content

Add commeent #10502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Add commeent #10502

merged 2 commits into from
Oct 10, 2021

Conversation

k-nasa
Copy link
Contributor

@k-nasa k-nasa commented Oct 10, 2021

Why

This code looks logic-bug ...

https://github.com/rust-analyzer/rust-analyzer/blob/ce86534e1cb22685e83c3f91ea89025edbfcbc98/crates/syntax/src/syntax_node.rs#L50

However, this code has been intentionally disabled.
It's a good idea to write a comment

ref: #10357

What

  • I added comment

@k-nasa k-nasa changed the title K nasa/add commeent Add commeent Oct 10, 2021
Comment on lines +50 to +51
// NOTE Why disabling assertions.
// ref: https://github.com/rust-analyzer/rust-analyzer/pull/10357
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// NOTE Why disabling assertions.
// ref: https://github.com/rust-analyzer/rust-analyzer/pull/10357
// Disable block validation, see https://github.com/rust-analyzer/rust-analyzer/pull/10357

@bors bors bot merged commit 820393f into rust-lang:master Oct 10, 2021
@lnicola
Copy link
Member

lnicola commented Oct 10, 2021

Ouch, bors closed this because it was included, then reverted, in #10504.

@lnicola
Copy link
Member

lnicola commented Oct 10, 2021

@k-nasa I can't reopen this PR, feel free to file a new one (but see my suggestion above).

@k-nasa k-nasa deleted the k-nasa/add_commeent branch October 10, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants