Skip to content

minor: Add comment #10506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2021
Merged

minor: Add comment #10506

merged 1 commit into from
Oct 10, 2021

Conversation

k-nasa
Copy link
Contributor

@k-nasa k-nasa commented Oct 10, 2021

Why

This code looks logic-bug ...

https://github.com/rust-analyzer/rust-analyzer/blob/ce86534e1cb22685e83c3f91ea89025edbfcbc98/crates/syntax/src/syntax_node.rs#L50

However, this code has been intentionally disabled.
It's a good idea to write a comment

ref: #10357

What

  • I added comment

@k-nasa
Copy link
Contributor Author

k-nasa commented Oct 10, 2021

@lnicola Sorry. I reopen it.

@lnicola
Copy link
Member

lnicola commented Oct 10, 2021

bors r+

changelog skip

@k-nasa
Copy link
Contributor Author

k-nasa commented Oct 10, 2021

Thanks

@bors
Copy link
Contributor

bors bot commented Oct 10, 2021

Build succeeded:

@bors bors bot merged commit 4439cd8 into rust-lang:master Oct 10, 2021
@k-nasa k-nasa deleted the add_comment branch October 10, 2021 08:05
@Veykril Veykril changed the title Add comment minor: Add comment Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-nasa @lnicola