internal: build per-block ItemTrees
#10863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-schievink
commented
Nov 25, 2021
| mod tests { | ||
| use super::*; | ||
| } | ||
| use crate::name; |
There was a problem hiding this comment.
Reordered so that the old code path was still hit with the more correct inner item handling.
| // Macros can expand to expressions. We return an empty item tree in this case, but | ||
| // still need to collect inner items. | ||
| ctx.lower_inner_items(e.syntax()) | ||
| }, |
There was a problem hiding this comment.
We no longer request ItemTrees of arbitrary macros (only of macros that can expand to statements), so these cases are gone
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 26, 2021
10865: internal: Use the right `ItemTree` when re-resolving attr r=jonas-schievink a=jonas-schievink Followup to #10863, which caused a panic when analyzing diesel bors r+ Co-authored-by: Jonas Schievink <[email protected]>
|
This (or the follow-up PR) reduced the memory usage on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7717
Fixes #8911
Fixes #8614
ItemTrees are now flat lists of items, so they should probably be renamed at some point.