minor: unblock metrics #11724
Merged
minor: unblock metrics #11724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC #11700. Should |
|
There's a |
|
Well now we get |
|
This time I don't see the problem though, @matklad |
|
Looks like it's failing at a different point, though, maybe around https://github.com/rust-analyzer/rust-analyzer/pull/11724/files#diff-9409e6ada47cec87a05099892afebc392835ec03643bad21e1f431819cbb2ea1L54? |
|
That's because |
This was referenced Mar 16, 2022
bors bot
added a commit
that referenced
this pull request
Mar 16, 2022
11727: minor: Fix metrics.json path r=jonas-schievink a=lnicola CC #11724 (comment) 11728: Try to fix nightlies r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Laurențiu Nicola <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
bors bot
added a commit
that referenced
this pull request
Mar 16, 2022
11727: minor: Fix metrics.json path r=lnicola a=lnicola CC #11724 (comment) 11728: Try to fix nightlies r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Laurențiu Nicola <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
bors bot
added a commit
that referenced
this pull request
Mar 16, 2022
11727: minor: Fix metrics.json path r=lnicola a=lnicola CC #11724 (comment) Co-authored-by: Laurențiu Nicola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't seem like you can inspect the error kind, so discarding the result it is
bors r+