fix: “Generate constant” ignores the path prefix of the identifier #12286
Conversation
harpsword
force-pushed
the
fix_generate_constant
branch
from
6376671 to
85ffba3
Compare
There was a problem hiding this comment.
Sorry this took me so long to get back to, I have lost sight of this PR because it does some things we probably want proper support for (like creating inline modules for a path) and I was thinking about how to do that properly.
With that said, I am still not really sure how to do this nicely so I think its better to merge this now instead of keeping it blocked. So if you could fix the one unwrap usage, I'll go ahead and merge this.
| let name_refs = path.segments().map(|s| s.name_ref()); | ||
| let mut outer_exists = false; | ||
| let mut not_exist_name_ref = Vec::new(); | ||
| let mut current_module = constant_module; | ||
| for name_ref in name_refs { | ||
| let name_ref_value = name_ref?; | ||
| let name_ref_class = NameRefClass::classify(&ctx.sema, &name_ref_value); | ||
| match name_ref_class { | ||
| Some(NameRefClass::Definition(Definition::Module(m))) => { | ||
| if !m.visibility(ctx.sema.db).is_visible_from(ctx.sema.db, constant_module.into()) { | ||
| return None; | ||
| } | ||
| outer_exists = true; | ||
| current_module = m; | ||
| } | ||
| Some(_) => { | ||
| return None; | ||
| } | ||
| None => { | ||
| not_exist_name_ref.push(name_ref_value); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I guess this is fine for now, but ideally we want a helper function here that just creates/resolves a path for all its modules, as this here doesn't cover some cases properly.
| if file_id.is_some() { | ||
| builder.edit_file(file_id.unwrap()); | ||
| } |
There was a problem hiding this comment.
| if file_id.is_some() { | |
| builder.edit_file(file_id.unwrap()); | |
| } | |
| if let Some(file_id) = file_id { | |
| builder.edit_file(file_id); | |
| } |
harpsword
force-pushed
the
fix_generate_constant
branch
from
85ffba3 to
b5aa3b3
Compare
|
Thanks |
|
☀️ Test successful - checks-actions |
fix #12022
add abilities to generate constant with prefix path, even these mods in path are not exist.
some examples
multi.path.mov
even.in.different.file.mov
simple.version.mov
generate.constant.which.prefix.not.exists.mov