Skip to content

fix: resolve associated types of bare dyn types #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

lowr
Copy link
Contributor

@lowr lowr commented Aug 17, 2022

Fixes #13031

We've been dropping the associated type bindings of trait object types that were written without the dyn keyword. This patch reuses the lowering logic for TypeRef::DynTrait so the associated type bindings are properly lowered.

@lowr lowr force-pushed the fix/bare-dyn-assoc-type branch from baa192c to 12abaf8 Compare August 17, 2022 22:05
@Veykril
Copy link
Member

Veykril commented Aug 18, 2022

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Aug 18, 2022

📌 Commit 12abaf8 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 18, 2022

⌛ Testing commit 12abaf8 with merge ae57b69...

@bors
Copy link
Contributor

bors commented Aug 18, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing ae57b69 to master...

@bors bors merged commit ae57b69 into rust-lang:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False diagnostic with dyn Traits
3 participants