fix: reorder dyn bounds on render #13382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Maybe add a FIXME to use https://doc.rust-lang.org/std/iter/trait.Iterator.html?search=vec#method.partition_in_place when it hits stable? If I'm reading this right, it would work here.
|
@bors delegate+ |
|
✌️ @lowr can now approve this pull request |
lowr
force-pushed
the
fix/reorder-dyn-bounds-on-render
branch
from
85dca06 to
5e43ea9
Compare
|
Yeah, I really wanted to use @bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13368
#13192 changed the order of dyn bounds, violating the contract with
write_bounds_like_dyn_trait()on render. The projection bounds are expected to come right after the trait bound they are accompanied with.Although the reordering procedure can be made a bit more efficient, I opted for relying only on the invariants currently documented in
lower_dyn_trait(). It's not the hottest path and dyn bounds tend to be short so I believe it shouldn't hurt performance noticeably.