Skip to content

feat: Make flycheck workdone progress reports cancellable #13427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Oct 17, 2022

In clients that support this (like VSCode), the clients will now render a cancel button on the notification message which can be clicked to cancel the flycheck instead.

Closes #6895
Code_VbXgP3SbFD

@Veykril
Copy link
Member Author

Veykril commented Oct 17, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2022

📌 Commit e41023c has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 17, 2022

⌛ Testing commit e41023c with merge 106285b...

@bors
Copy link
Contributor

bors commented Oct 17, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 106285b to master...

@bors bors merged commit 106285b into rust-lang:master Oct 17, 2022
@jmg-duarte
Copy link

Amazing work 🎉 thank you!

@Veykril Veykril deleted the cancel-check branch October 17, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VSCode] Allow to stop cargo on command
3 participants